Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Add missing space before closing bracket in if statements #65

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

SimonRit
Copy link
Collaborator

@SimonRit SimonRit commented Jul 4, 2023

The error message on the GitHub actions log was
[: missing `]'

The error message on the GitHub actions log was
[: missing `]'
@dzenanz dzenanz requested a review from tbirdso July 4, 2023 13:16
@dzenanz dzenanz merged commit edd0a43 into InsightSoftwareConsortium:main Jul 4, 2023
@tbirdso
Copy link
Collaborator

tbirdso commented Jul 5, 2023

👍

@dzenanz
Copy link
Member

dzenanz commented Jul 5, 2023

I merged this yesterday without waiting for further approvals because I wanted to have it for KitwareMedical/ITKUltrasound#232.

@tbirdso
Copy link
Collaborator

tbirdso commented Jul 5, 2023

I merged this yesterday without waiting for further approvals because I wanted to have it for KitwareMedical/ITKUltrasound#232.

Yes no problem, I agree with this decision. The fix here is minor.

N-Dekker added a commit to InsightSoftwareConsortium/ITKElastix that referenced this pull request Jul 20, 2023
Upgraded ITKRemoteModuleBuildTestPackageAction to the latest revision from its
main, from 2023-07-04. Aims to fix GitHub CI failures, especially from
"cxx-build-workflow / build-test-cxx (windows-2022)".

Including:

  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#65
  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction@edd0a43
  BUG: Add missing space before closing bracket in if statements

  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#64
  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction@1514c2c
  COMP: Do not change location when launching VS development shell

Suggested by Dženan Zukić and Tom Birdsong.
dzenanz pushed a commit to InsightSoftwareConsortium/ITKElastix that referenced this pull request Jul 20, 2023
Upgraded ITKRemoteModuleBuildTestPackageAction to the latest revision from its
main, from 2023-07-04. Aims to fix GitHub CI failures, especially from
"cxx-build-workflow / build-test-cxx (windows-2022)".

Including:

  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#65
  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction@edd0a43
  BUG: Add missing space before closing bracket in if statements

  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction#64
  InsightSoftwareConsortium/ITKRemoteModuleBuildTestPackageAction@1514c2c
  COMP: Do not change location when launching VS development shell

Suggested by Dženan Zukić and Tom Birdsong.
@SimonRit SimonRit deleted the space_bracket branch June 5, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants