Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add CI. #8

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Conversation

jhlegarreta
Copy link
Member

  • Add *.yml configuration files for CI.
  • Update the README.rst file to reflect the CI status.
  • Modify the current CTestConfig.cmake file to make the build
    results be sent to the Insight project in open.cdash.org.
  • Add the necessary *.wrap files.
  • Add the setup.py file for Python packaging.
  • Modify the itk-module.cmake to take advantage of the module
    documentation in the README.rst file.
  • Take advantage to improve the README file contents.

@jhlegarreta
Copy link
Member Author

The *.wrap files need a revision; their magic is still elusive to me, and I just draw some inspiration from existing files in ITK.

@sudomakeinstall
Copy link
Member

Haha you're on a roll. Their magic is elusive to me as well--I'll need to leave it to someone else (Matt?
@thewtex ) to check this. But thanks so much for the PR!

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @jhlegarreta !

I enabled the CI services.

A minor issue noted inline.

README.rst Outdated Show resolved Hide resolved
- Add `*.yml` configuration files for CI.
- Update the `README.rst` file to reflect the CI status.
- Modify the current `CTestConfig.cmake` file to make the build
  results be sent to the **Insight** project in **open.cdash.org**.
- Add the necessary `*.wrap` files.
- Add the `setup.py` file for Python packaging.
- Modify the `itk-module.cmake` to take advantage of the module
  documentation in the `README.rst` file.
- Take advantage to improve the `README` file contents.
@thewtex
Copy link
Member

thewtex commented Oct 18, 2018

LGTM

@hjmjohnson hjmjohnson merged commit 80d7815 into InsightSoftwareConsortium:master Nov 4, 2018
@jhlegarreta jhlegarreta deleted the AddCI branch November 4, 2018 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants