Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for ITKv5.2 code cleanups ... ROUND1 #19

Merged
merged 4 commits into from
Feb 20, 2020
Merged

Updates for ITKv5.2 code cleanups ... ROUND1 #19

merged 4 commits into from
Feb 20, 2020

Conversation

hjmjohnson
Copy link
Member

No description provided.

@hjmjohnson hjmjohnson requested a review from dzenanz February 19, 2020 20:01
@hjmjohnson hjmjohnson self-assigned this Feb 19, 2020
Copy link
Member

@sudomakeinstall sudomakeinstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

```
git filter-branch -f \
--tree-filter "~/ITK/Utilities/Maintenance/clang-format.bash --clang-format ~/Dashboard/src/ITK-clang11/clang-format-Linux --tracked" \
    master..
```
This check replaces default bodies of special member functions with
= default;. The explicitly defaulted function declarations enable more
opportunities in optimization, because the compiler might treat
explicitly defaulted functions as trivial.

Additionally, the C++11 use of = default more clearly expreses the
intent for the special member functions.
Find and remove redundant void argument lists.
The mission of NumFOCUS is to promote open
practices in research, data, and scientific
computing.

https://numfocus.org
@dzenanz dzenanz merged commit 9bb48f4 into master Feb 20, 2020
@dzenanz dzenanz deleted the ITKv5_1rc2 branch February 20, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants