Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Follow repository naming convention. #13

Conversation

jhlegarreta
Copy link
Member

Follow remote module repository naming convention: add the ITK prefix to
the project name, and keep the prefix out of the module name.

Specifically:

  • Fix the module name in the main CMakeLists.txt file.
  • Fix the module name in the wrapping CMakeLists.txt file.
  • Fix the module name in the itk-module.cmake file.
  • Fix the project name in the setup section of the setup.py file.
  • Change the project name in the config.yml Circle CI yml file.
  • Fix the module name for the \ingroup Doxygen documentation
    keyword.
  • Take advantage of the change to set the URL to the repository site in
    setup.py.
  • Take advantage of the change to add keywords describing the module to
    setup.py.

@jhlegarreta jhlegarreta force-pushed the FollowRemoteModuleNamingConvention branch from 0728f64 to a404887 Compare November 24, 2018 01:32
Follow remote module repository naming convention: add the `ITK` prefix to
the **project name**, and keep the prefix out of the **module name**.

Specifically:
- Fix the **module name** in the main `CMakeLists.txt` file.
- Fix the **module name** in the wrapping `CMakeLists.txt` file.
- Fix the **module name** in the `itk-module.cmake` file.
- Fix the **project name** in the `setup` section of the `setup.py` file.
- Change the **project name** in the `config.yml` Circle CI `yml` file.
- Fix the **module name** for the `\ingroup` Doxygen documentation
  keyword.
- Take advantage of the change to set the URL to the repository site in
  `setup.py`.
- Take advantage of the change to add keywords describing the module to
  `setup.py`.
@jhlegarreta jhlegarreta force-pushed the FollowRemoteModuleNamingConvention branch from a404887 to e01cf94 Compare November 24, 2018 01:41
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @jhlegarreta !

@thewtex thewtex merged commit 9a4988c into InsightSoftwareConsortium:master Nov 26, 2018
@jhlegarreta jhlegarreta deleted the FollowRemoteModuleNamingConvention branch November 26, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants