STYLE: Factor out itkOMEZarrNGFFCommon.h #65
Conversation
For re-use across ImageIO and TransformIO. OMEZarrNGFFAxis is renamed to OMEZarrAxis for brevity. Also, what was previously ambigiously ome-zarr-ngff is now OME-Zarr.
| * | ||
| * \ingroup IOOMEZarrNGFF | ||
| */ | ||
| struct IOOMEZarrNGFF_EXPORT OMEZarrNGFFAxis |
There was a problem hiding this comment.
Rebase gone wrong? This was moved to common header in previous commit.
| * the "file name", using pattern address.memory, where address is a | ||
| * decimal representation of BufferInfo's address. | ||
| * Sample filename: "12341234.memory". */ | ||
| using BufferInfo = struct |
There was a problem hiding this comment.
This feels like it should be part of the common class for imageIO and transformIO.
|
|
||
| /** Construct a "magic" file name from the provided bufferInfo. */ | ||
| static std::string | ||
| MakeMemoryFileName(const BufferInfo & bufferInfo) |
There was a problem hiding this comment.
Also should be common for imageIO and transformIO.
| ReadArrayMetadata(std::string path, std::string driver); | ||
|
|
||
| private: | ||
| // An empty zip file consists of 22 bytes of "end of central directory" record. More: |
There was a problem hiding this comment.
also common for imageIO and transformIO
| bool | ||
| OMEZarrNGFFTransformIO::CanReadFile(const char * filename) | ||
| { | ||
| try |
There was a problem hiding this comment.
Maybe have this function in common class for imageIO and transformIO, and then just inherit it, or at least invoke it, instead of duplicate it?
| find_package(ITK 5.0 REQUIRED) | ||
| find_package(ITK 5.4 REQUIRED) |
There was a problem hiding this comment.
The upgrade of ITK seems unrelated to/independent of the rest of the commit ("Factor out itkOMEZarrNGFFCommon.h"). If so, preferably make it a separate commit.
For re-use across ImageIO and TransformIO.
OMEZarrNGFFAxis is renamed to OMEZarrAxis for brevity. Also, what was
previously ambigiously ome-zarr-ngff is now OME-Zarr.