Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Require at least ITK 5.4rc2, for ImageRandomIteratorWithIndex #256

Closed

Conversation

N-Dekker
Copy link
Collaborator

Especially to avoid potential differences between registration results of the elastix executable and ITKElastix, which were accidentally introduced with ITK 5.4rc1 and fixed with ITK 5.4rc2:

pull request InsightSoftwareConsortium/ITK#4183
commit InsightSoftwareConsortium/ITK@997ff54
BUG: ImageRandomIteratorWithIndex should not assign data in constructor

Especially to avoid potential differences between registration results of the
elastix executable and ITKElastix, which were accidentally introduced with ITK
5.4rc1 and fixed with ITK 5.4rc2:

  pull request InsightSoftwareConsortium/ITK#4183
  commit InsightSoftwareConsortium/ITK@997ff54
  BUG: ImageRandomIteratorWithIndex should not assign data in constructor
@tbirdso
Copy link
Collaborator

tbirdso commented Nov 1, 2023

@N-Dekker Thanks for making this change. We should also update CI to build with ITK v5.4rc2 packages and bump the package version. I've forked your branch and added those changes in #260, let's continue discussion there.

@tbirdso tbirdso closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants