Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Bump elastix version to version 5.1.0 #192

Merged

Conversation

N-Dekker
Copy link
Collaborator

@N-Dekker N-Dekker commented Jan 12, 2023

elastix 5.1.0 is about to be released, this should be its final commit: SuperElastix/elastix@d652938

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🌮

@N-Dekker
Copy link
Collaborator Author

Test notebooks / nbmake (ubuntu-22.04) fails, https://github.com/InsightSoftwareConsortium/ITKElastix/actions/runs/3902985074/jobs/6666735534#step:5:46 says:

ValueError                                Traceback (most recent call last)
File /opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/monai/transforms/transform.py:102, in apply_transform(transform, data, map_items, unpack_items, log_stats)
    101         return [_apply_transform(transform, item, unpack_items) for item in data]
--> 102     return _apply_transform(transform, data, unpack_items)
    103 except Exception as e:
    104     # if in debug mode, don't swallow exception so that the breakpoint
    105     # appears where the exception was raised.

File /opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/monai/transforms/transform.py:66, in _apply_transform(transform, parameters, unpack_parameters)

Any clue?

@thewtex
Copy link
Member

thewtex commented Jan 12, 2023

Should be fixed by: #191

@N-Dekker N-Dekker force-pushed the Bump-elastix-to-version-5.1.0 branch from 247746b to aab2f83 Compare January 16, 2023 14:40
@N-Dekker N-Dekker force-pushed the Bump-elastix-to-version-5.1.0 branch from aab2f83 to 2a89eb7 Compare February 10, 2023 16:16
@N-Dekker
Copy link
Collaborator Author

https://open.cdash.org/viewBuildError.php?type=1&buildid=8466008 (N-Dekker/ITKElastix-macos-12--refs/heads/Bump-elastix-to-version-5.1.0) says:

KWStyle/kwsCheckLineLength.cxx:24:3: warning: 'sprintf' is deprecated: This function is provided for compatibility reasons only. Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Wdeprecated-declarations]

This warning does not seem specific to this pull request. Still the CI considers it a show stopper. What to do?

@thewtex
Copy link
Member

thewtex commented Feb 13, 2023

@N-Dekker these warnings should be addressed by #196

@N-Dekker N-Dekker force-pushed the Bump-elastix-to-version-5.1.0 branch from 2a89eb7 to bc0adb6 Compare February 13, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants