Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Bump ITK workflow for v5.3rc04.post4 #178

Merged
merged 1 commit into from
Nov 21, 2022
Merged

ENH: Bump ITK workflow for v5.3rc04.post4 #178

merged 1 commit into from
Nov 21, 2022

Conversation

tbirdso
Copy link
Collaborator

@tbirdso tbirdso commented Nov 18, 2022

No description provided.

@tbirdso tbirdso requested a review from dzenanz November 18, 2022 14:05
@tbirdso tbirdso merged commit 58ab165 into main Nov 21, 2022
@N-Dekker
Copy link
Collaborator

@tbirdso Was this really ready for merge? You see, the notebook tests still had failures.

@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 21, 2022

Hi @N-Dekker , those notebook failures are also discussed in #176 and #177:

It seems that all notebook kernels are dead now. Is it a problem of itk-elastix with itk=5.3rc04.post4? Because I see that I have the same issue locally - python exits abruptly without an error and notebook kernel dies again without an error. itk=5.3rc04.post3 works fine though.

It sounds like a likely cause is some incompatibility between ITK v5.3rc04.post4 wheels and the ITKElastix wheels built for v5.3rc04.post3. The changes in this PR were required for tagging a new version itk-elastix==0.14.4 built against ITK v5.3rc04.post4.

Once itk-elastix 0.14.4 wheels are available on PyPI in a couple of hours I will re-run notebook CI to see if the issue is addressed. If not, we should continue discussion in #177.

@tbirdso tbirdso linked an issue Nov 21, 2022 that may be closed by this pull request
@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 21, 2022

@N-Dekker as hoped, notebook checks are passing again with the 0.14.4 release.

https://github.com/InsightSoftwareConsortium/ITKElastix/actions/runs/3514782410/jobs/5894120148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

itk-elastix version 0.14.3 results in segmentation fault
3 participants