ENH: Add ipynb examples Transformix, image, mesh, TranslationTransform #175
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,127 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #9. print()
Nice.
A possible shortcut here:
import numpy as npprint(np.asarray(image))
Reply via ReviewNB
There was a problem hiding this comment.
Thanks @thewtex I just replaced my little hand-written "print_image" helper by your suggested print(np.asarray(image)). Much better 👍
| @@ -0,0 +1,127 @@ | |||
| { | |||
There was a problem hiding this comment.
Line #27. moving_image.SetPixel([column, row], pixel_value)
Possible shortcut (untested), something like:
moving_image[:] = np.arange(len(itk.array_view_from_image(moving_image))
Reply via ReviewNB
|
Cool @N-Dekker ! |
|
Thanks for your comments so for @thewtex After the weekend, I think I'll have time to try out your numpy based suggestions. Interesting! I'm not very experienced with Jupyter Notebook, so I'm very interested to hear any more suggestions. Are the two examples I'm proposing here clear enough? |
|
@N-Dekker looking awesome! The examples are nice and clear. It may help to "tell a story" by breaking up the code into more cells and viewing intermediate output, maybe add some Markdown cells that explain what is going on. |
N-Dekker
force-pushed
the
ITK_Example_Transformix_Translation
branch
from
2aabcf5 to
db606f8
Compare
Thanks @thewtex, I included this suggestion with the latest force-push, please check! |
N-Dekker
force-pushed
the
ITK_Example_Transformix_Translation
branch
2 times, most recently
from
df7c3e2 to
35165f2
Compare
Added examples on how to use recently added TransformixFilter member functions, `SetTransform`, `SetInputMesh`, and `GetOutputMesh`. With help from Matt McCormick and Konstantinos Ntatsis.
N-Dekker
force-pushed
the
ITK_Example_Transformix_Translation
branch
from
35165f2 to
8353a74
Compare
| "\n", | ||
| "print('Output image:')\n", | ||
| "print(np.asarray(output_image))\n", | ||
| "print()" |
There was a problem hiding this comment.
Where is this print command for?
There was a problem hiding this comment.
print() just prints a line-break. But I guess I could have done print(np.asarray(output_image), "\n"), instead of line 148-149.
|
python-build-workflow / build-macos-python-packages says:
|
I restarted the failed jobs. |
Added examples on how to use recently added TransformixFilter member functions,
SetTransform,SetInputMesh, andGetOutputMesh.