Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Move GDCM version check to cxx file #4998

Merged

Conversation

blowekamp
Copy link
Member

Addresses warning about undefined GDCM_MAJOR_VERSION.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

Addresses warning about undefined GDCM_MAJOR_VERSION.
@github-actions github-actions bot added type:Compiler Compiler support or related warnings area:IO Issues affecting the IO module labels Nov 28, 2024
@blowekamp
Copy link
Member Author

@seanm Can check that this addresses the issue?

@seanm
Copy link
Contributor

seanm commented Nov 28, 2024

Will certainly fix my own CI, since only ITK header warnings will appear on it. I don't recall if ITK source is -Wundef clean or not...

I vote merge :)

@blowekamp blowekamp merged commit c9419ca into InsightSoftwareConsortium:master Nov 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:IO Issues affecting the IO module type:Compiler Compiler support or related warnings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants