Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: zlib-ng address cmake deprecation warnings about version #4992

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

COMP: zlib-ng address cmake deprecation warnings about version #4992

wants to merge 1 commit into from

Conversation

blowekamp
Copy link
Member

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@github-actions github-actions bot added type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:ThirdParty Issues affecting the ThirdParty module labels Nov 26, 2024
dzenanz
dzenanz reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does upstream have now? There is an update script, have you tried updating zlib-ng?

@blowekamp
Copy link
Member Author

There is not an update upstream. I need to make a PR upstream.

Morst third party projects are using the warning probelmatic form of zlib-ng and not the more robust: cmake_minimum_required(VERSION <min>...<policy_max>) format.

@blowekamp
Copy link
Member Author

PR made upstream: zlib-ng/zlib-ng#1812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz left review comments

@hjmjohnson hjmjohnson hjmjohnson approved these changes

Assignees
No one assigned
Labels
area:ThirdParty Issues affecting the ThirdParty module type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blowekamp @hjmjohnson @dzenanz