Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYLE: Remove support for 10+ year old GDCM #4986

Merged
merged 1 commit into from
Nov 25, 2024
Merged

STYLE: Remove support for 10+ year old GDCM #4986

merged 1 commit into from
Nov 25, 2024

Conversation

hjmjohnson
Copy link
Member

Remove support for system installed versions of GDCM that are more than 10 years old.

This simplifies the codebase for code that has likely not been explicitly tested in a very long time.

PR Checklist

@hjmjohnson
STYLE: Remove support for 10+ year old GDCM
4b8b967 
Remove support for system installed versions of GDCM that are more than
10 years old.

This simplifies the codebase for code that has likely not been
explicitly tested in a very long time.
@hjmjohnson hjmjohnson added the type:Style Style changes: no logic impact (indentation, comments, naming) label Nov 24, 2024
@hjmjohnson hjmjohnson added this to the ITK 6.0 Beta 1 milestone Nov 24, 2024
@hjmjohnson hjmjohnson self-assigned this Nov 24, 2024
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:IO Issues affecting the IO module labels Nov 24, 2024
blowekamp
blowekamp approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good over all, but consider using a CMake check to give a quicker notification to developers.

Modules/IO/GDCM/include/itkGDCMImageIO.h Show resolved Hide resolved
malaterre
malaterre approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@malaterre malaterre left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thanks

@hjmjohnson hjmjohnson merged commit a8580e2 into InsightSoftwareConsortium:master Nov 25, 2024
17 checks passed
@hjmjohnson hjmjohnson deleted the remove-old-gdcm-support branch November 25, 2024 15:14
dzenanz
dzenanz approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as-is, would be better with Brad's suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@blowekamp blowekamp blowekamp approved these changes

@malaterre malaterre malaterre approved these changes

Assignees

@hjmjohnson hjmjohnson

Labels
area:IO Issues affecting the IO module type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
ITK 6.0 Beta 1
Development

Successfully merging this pull request may close these issues.
4 participants
@hjmjohnson @malaterre @blowekamp @dzenanz