STYLE: Replace integer literals which are cast to bool. #4983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finds and replaces integer literals which are cast to bool.
cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-*,modernize-use-bool-literals -header-filter=.* -fix
hjmjohnson
added
the
type:Style
github-actions
bot
added
type:Testing
|
@N-Dekker After all the headache I caused in the previous big commit, I opted for a smaller commit this time :) . |
dzenanz
approved these changes
Nov 24, 2024
N-Dekker
approved these changes
Nov 24, 2024
| @@ -92,7 +92,7 @@ itkScalarImageToTextureFeaturesFilterTest(int, char *[]) | |||
| for (int i = 0; i < 5; ++i) | |||
| for (int j = 0; j < 5; j++, ++maskIt) | |||
| { | |||
| maskIt.Set(bool{ 1 }); | |||
There was a problem hiding this comment.
Approved of course, but what about itk::NumericTraits<bool>::OneValue()? 😺
There was a problem hiding this comment.
@hjmjohnson I just "unresolved" because I did not see a "resolution" to my remark on itk::NumericTraits<bool>::OneValue(). What do you think?
There was a problem hiding this comment.
That's quite a round-about way to write true. There is no need to overcomplicate things. itk::NumericTraits<bool>::OneValue() exists primarily to ease implementing templated code.
hjmjohnson
merged commit 2792d9a
into
InsightSoftwareConsortium:master
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finds and replaces integer literals which are cast to bool.
cd ${BLDDIR}
run-clang-tidy.py -extra-arg=-D__clang__ -checks=-,modernize-use-bool-literals -header-filter=. -fix
PR Checklist