-
-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add example of OrientImageFilter #4963
ENH: Add example of OrientImageFilter #4963
Conversation
Sample output:
Do we have any existing testing data that is 3D with an interesting matrix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blowekamp I am approving as is because this represents a sufficiently beneficial example.
I agree that it would be better to have a test case with an interesting matrix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good even as-is.
orienter->SetDesiredCoordinateOrientation(desiredCoordinateOrientation); | ||
|
||
|
||
// Create and set up a writer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could simplify this by using itk::WriteImage(orienter->GetOutput());
|
||
// Create and set up an OrientImageFilter | ||
using OrientImageFilterType = itk::OrientImageFilter<ImageType, ImageType>; | ||
OrientImageFilterType::Pointer orienter = OrientImageFilterType::New(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Minor suggestion: you may replace
OrientImageFilterType::Pointer
withauto
here! No need to wait for a follow-up to Modernize initialization of local SmartPointer variables #4964 (comment) 😃
d3a8a1f
into
InsightSoftwareConsortium:master
Nice! |
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.