Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VectorContainer Identifier template argument from DefaultStaticMeshTraits, tests, and comments #4879

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Remove VectorContainer Identifier template argument from DefaultStaticMeshTraits, tests, and comments #4879

merged 3 commits into from
Oct 17, 2024

Conversation

N-Dekker
Copy link
Contributor

Note that this pull request should not affect the API or the ABI of ITK in any way. 😇

@N-Dekker
STYLE: Remove VectorContainer Identifier template argument in MeshTraits
f613c01 
Following pull request InsightSoftwareConsortium#4856
commit edae0bc
"STYLE: Remove IdentifierType template argument from VectorContainer uses"
@N-Dekker
STYLE: Remove VectorContainer Identifier template argument from tests
bd8dd03 
Simplified the tests by just using the default element identifier type, which is
`itk::SizeValueType`.

Following pull request InsightSoftwareConsortium#4856
commit edae0bc
"STYLE: Remove IdentifierType template argument from VectorContainer uses"
@N-Dekker
STYLE: Remove VectorContainer Identifier template argument from comments
4dd443a 
Following pull request InsightSoftwareConsortium#4856
commit edae0bc
"STYLE: Remove IdentifierType template argument from VectorContainer uses"
@github-actions github-actions bot added type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Registration Issues affecting the Registration module area:Numerics Issues affecting the Numerics module labels Oct 10, 2024
@N-Dekker N-Dekker marked this pull request as ready for review October 10, 2024 11:59
@dzenanz dzenanz merged commit c103044 into InsightSoftwareConsortium:master Oct 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@blowekamp blowekamp blowekamp approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@N-Dekker @blowekamp @dzenanz