Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Fix for gcc13.2 compiler test failures #4636

Closed
wants to merge 1 commit into from
Closed

COMP: Fix for gcc13.2 compiler test failures #4636

wants to merge 1 commit into from

Commits on May 5, 2024

  1. COMP: Fix for gcc13.2 compiler test failures 

    Three tests fail in ITK for Release and RelWithDebInfo builds on Ubuntu 24.04 with GCC 13.2:
itkGDCMLegacyMultiFrameTest (Failed)
itkGDCMImageReadWriteTest_MultiFrameMRIZSpacing (Failed)
itkGDCM_ComplianceTest_singlebit (Failed)

(Note: Debug builds do not fail these tests)

The initial review of the code did not indicate a problem, but it looks like perhaps an over-optimization that removes variables and causes the incorrect behavior to occur.

The function "FindDataElement" had duplicate code from "GetDataElement" so made "FindDataElement" use the "GetDataElement" working function.
    @hjmjohnson
    hjmjohnson committed May 5, 2024
    Configuration menu
    Copy the full SHA
    8eeba79 View commit details
    Browse the repository at this point in the history