Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: DO NOT MERGE: Test for Apply Clang Format Action #3574

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Aug 24, 2022

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@thewtex
Copy link
Member Author

thewtex commented Aug 24, 2022

Re: #3571

@thewtex thewtex added the action:ApplyClangFormat Add this label to a pull request to apply `clang-format` to the branch label Aug 24, 2022
@github-actions github-actions bot added the area:Core Issues affecting the Core module label Aug 24, 2022
@thewtex
Copy link
Member Author

thewtex commented Aug 26, 2022

Looks like the action itself needs updates.

@jhlegarreta
Copy link
Member

Looks like the action itself needs updates.

Is it that we need write permissions here instead of read permissions?
https://github.com/InsightSoftwareConsortium/ITK/blob/master/.github/workflows/clang-format-linter.yml#L6

@thewtex
Copy link
Member Author

thewtex commented Dec 21, 2022

Rebasing on master so we can get a fresh run...

Recent RTK updates have removed compiler warnings.
sscanf the values directly into the vect3d.
Detect local variable declaration statements and update to have only one
statement per declaration.

Multiple declarations in a single statement reduces readability. Clang-tidy
places one line per declaration, which often indicates that the variables are
declared before initialization.

This also eases code refactoring via regular expression matching.
Detect local variable declaration statements and update to have only one
statement per declaration.

Multiple declarations in a single statement reduces readability. Clang-tidy
places one line per declaration, which often indicates that the variables are
declared before initialization.

This also eases code refactoring via regular expression matching.
Detect local variable declaration statements and update to have only one
statement per declaration.

Multiple declarations in a single statement reduces readability. Clang-tidy
places one line per declaration, which often indicates that the variables are
declared before initialization.

This also eases code refactoring via regular expression matching.
Detect local variable declaration statements and update to have only one
statement per declaration.

Multiple declarations in a single statement reduces readability. Clang-tidy
places one line per declaration, which often indicates that the variables are
declared before initialization.

This also eases code refactoring via regular expression matching.
Detect local variable declaration statements and update to have only one
statement per declaration.

Multiple declarations in a single statement reduces readability. Clang-tidy
places one line per declaration, which often indicates that the variables are
declared before initialization.

This also eases code refactoring via regular expression matching.
@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:Examples Demonstration of the use of classes type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module area:Segmentation Issues affecting the Segmentation module area:Numerics Issues affecting the Numerics module area:Remotes Issues affecting the Remote module labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action:ApplyClangFormat Add this label to a pull request to apply `clang-format` to the branch area:Core Issues affecting the Core module area:Examples Demonstration of the use of classes area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Registration Issues affecting the Registration module area:Remotes Issues affecting the Remote module area:Segmentation Issues affecting the Segmentation module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants