COMP: Fix older gcc build error including "cstddef" for "ptrdiff_t" #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:Core
jcfr
added
the
action:ApplyClangFormat
This commit fixes a regression likely introduced in c173dfd (STYLE: Remove `std::` prefix from types that work without it) to support building ITK wheels using manylinux_2_24 providing gcc 6.3. It fixes build error like the following: In file included from /work/ITK-source/ITK/Modules/Core/Common/include/itkImageRegion.h:33:0, from /work/ITK-source/ITK/Modules/Core/Common/include/itkMultiThreaderBase.h:35, from /work/ITK-source/ITK/Modules/Core/Common/src/itkTotalProgressReporter.cxx:19: /work/ITK-source/ITK/Modules/Core/Common/include/itkSize.h:242:27: error: ‘ptrdiff_t’ does not name a type using difference_type = ptrdiff_t; ^~~~~~~~~
thewtex
force-pushed
the
fix-older-gcc-adding-missing-include-for-ptrdiff_t
branch
from
8ca6e8d
to
0563258
Compare
|
Addressed clang-format issues locally (the applyClangFormat label / action has permissions issue). |
thewtex
approved these changes
Jun 23, 2022
|
👍 thanks jcfr 🙏 |
|
Thanks @thewtex for the follow up 💯 |
|
\azp run ITK.macOS |
|
/azp run ITK.macOS |
hjmjohnson
approved these changes
Jun 24, 2022
|
🚀 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression likely introduced in c173dfd (STYLE: Remove
std::prefix from types that work without it) to support building ITK wheels using manylinux_2_24 providing gcc 6.3.It fixes build error like the following:
cc: @Leengit
PR Checklist