Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Register ComposeScaleSkewVersor3DTransform transform #2483

Conversation

blowekamp
Copy link
Member

This is required to read and write the transform.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@blowekamp
Copy link
Member Author

This PR should be merged into the release branch too.

Copy link
Member

@aylward aylward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dzenanz
Copy link
Member

dzenanz commented Apr 14, 2021

Homebrew's CMake download location gives 404: {"errors":[{"code":"UNAUTHORIZED","message":"authentication required"}]}. I have seen a similar error on some CI before. Is this now broken or merely intermittent?

@dzenanz
Copy link
Member

dzenanz commented Apr 14, 2021

#2484 has the same Mac build issue. @seanm and anyone else routinely using Macs: Do we know why this broke? And how to best fix it?

@seanm
Copy link
Contributor

seanm commented Apr 14, 2021

Did it break on my bots? If so, I keep a log of when I do any updates on them... What broke when and where?

@dzenanz
Copy link
Member

dzenanz commented Apr 14, 2021

MacOS CI is now failing for PRs here on GitHub. Here is a copy of the log:

Starting: Build and test
==============================================================================
Task         : Bash
Description  : Run a Bash script on macOS, Linux, or Windows
Version      : 3.182.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
==============================================================================
Generating script.
========================== Starting Command Output ===========================
/bin/bash --noprofile --norc /Users/runner/work/_temp/8d845d24-e341-4ad0-a9dd-d2397d5c9f47.sh
+ curl -O https://raw.githubusercontent.com/Homebrew/homebrew-core/de946dd0c0a91ecf6c78c843a4580bd7116c6bf0/Formula/cmake.rb
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  1917  100  1917    0     0  50447      0 --:--:-- --:--:-- --:--:-- 50447
+ brew unlink cmake
Unlinking /usr/local/Cellar/cmake/3.20.1... 36 symlinks removed.
+ brew install ./cmake.rb
Warning: Calling `cellar` in a bottle block is deprecated! Use `brew style --fix` on the formula to update the style or use `sha256` with a `cellar:` argument instead.
Warning: Calling `sha256 "digest" => :tag` in a bottle block is deprecated! Use `brew style --fix` on the formula to update the style or use `sha256 tag: "digest"` instead.
Warning: Calling `sha256 "digest" => :tag` in a bottle block is deprecated! Use `brew style --fix` on the formula to update the style or use `sha256 tag: "digest"` instead.
Warning: Calling `sha256 "digest" => :tag` in a bottle block is deprecated! Use `brew style --fix` on the formula to update the style or use `sha256 tag: "digest"` instead.
Warning: Calling `sha256 "digest" => :tag` in a bottle block is deprecated! Use `brew style --fix` on the formula to update the style or use `sha256 tag: "digest"` instead.
Error: Failed to load cask: ./cmake.rb
Cask 'cmake' is unreadable: wrong constant name #<Class:0x00007ff101304ec8>
Warning: Treating ./cmake.rb as a formula.
==> Downloading https://ghcr.io/v2/homebrew/core/cmake/manifests/3.18.4
curl: (22) The requested URL returned error: 404 
Error: Failed to download resource "cmake_bottle_manifest"
Download failed: https://ghcr.io/v2/homebrew/core/cmake/manifests/3.18.4
+ c++ --version
Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin19.6.0
Thread model: posix
InstalledDir: /Applications/Xcode_12.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
+ cmake --version
/Users/runner/work/_temp/8d845d24-e341-4ad0-a9dd-d2397d5c9f47.sh: line 8: cmake: command not found
+ ctest -S /Users/runner/work/1/ITK-dashboard/dashboard.cmake -VV -j 4
/Users/runner/work/_temp/8d845d24-e341-4ad0-a9dd-d2397d5c9f47.sh: line 10: ctest: command not found
##[error]Bash exited with code '127'.
Finishing: Build and test

@seanm
Copy link
Contributor

seanm commented Apr 14, 2021

cmake: command not found -> I guess github borked something.

blowekamp added a commit to SimpleITK/SimpleITK that referenced this pull request Apr 14, 2021
This is required to read and write the transform.
@blowekamp blowekamp force-pushed the RegisterComposeScaleSkewVersor3DTransform branch from c1aa570 to 8c7784d Compare April 15, 2021 13:08
dzenanz referenced this pull request Apr 18, 2021
This is equivalent to Slicer's "Harden Transform" operation.
@dzenanz dzenanz mentioned this pull request Apr 18, 2021
@dzenanz
Copy link
Member

dzenanz commented Apr 18, 2021

I created #2492 to track Mac CI issue.

@blowekamp
Copy link
Member Author

Can we merge?

@dzenanz
Copy link
Member

dzenanz commented Apr 19, 2021

We can.

@blowekamp blowekamp merged commit d5db8c2 into InsightSoftwareConsortium:master Apr 20, 2021
dave3d pushed a commit to dave3d/SimpleITK that referenced this pull request Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants