Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Fix warning in PointSetToPointSetMetricv4 #1820

Merged
merged 2 commits into from
May 14, 2020

Conversation

dyollb
Copy link
Contributor

@dyollb dyollb commented May 13, 2020

change index type to SizeValueType in functor for ParallelizeArray
also change start/end index type to SizeValueType.

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed), itkEuclideanDistancePointSetMetricRegistrationTest.cxx is sufficient to reproduce issue
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@dzenanz
Copy link
Member

dzenanz commented May 13, 2020

The commit needs to have COMP: prefix. Prefixes are not necessary for GitHub pull requests (and are frequently absent for multi-commit PRs). Can you update and force push?

change index type to SizeValueType in functor for ParallelizeArray
also change start/end index type to SizeValueType.
@dzenanz
Copy link
Member

dzenanz commented May 13, 2020

There are a couple alignment issues (using GitHub UI bypasses commit hook which applies the code style). Details here (also accessible via details link in the above list of checks).

@dyollb
Copy link
Contributor Author

dyollb commented May 13, 2020

action:ApplyClangFormat

@dzenanz dzenanz added the action:ApplyClangFormat Add this label to a pull request to apply `clang-format` to the branch label May 13, 2020
@dzenanz
Copy link
Member

dzenanz commented May 13, 2020

Unfortunately, this does not work for PRs from forks, only from branches in the main repo.

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. To be squashed upon merge.

@dzenanz dzenanz merged commit 0892462 into InsightSoftwareConsortium:master May 14, 2020
@dyollb
Copy link
Contributor Author

dyollb commented May 26, 2020

@dzenanz will this be merged into the 5.1 release? thanks

@dzenanz
Copy link
Member

dzenanz commented May 26, 2020

You could make a new PR into the release branch, with this same patch. As 5.1.0 is already tagged, it would go into 5.1.1, sometime in the future.

thewtex pushed a commit that referenced this pull request May 26, 2020
COMP: Fix warning in PointSetToPointSetMetricv4

change index type to SizeValueType in functor for ParallelizeArray
also change start/end index type to SizeValueType.

Co-authored-by: Bryn Lloyd <[email protected]>
@thewtex
Copy link
Member

thewtex commented May 26, 2020

This has been merged into the release branch for inclusion in 5.1.1.

@dyollb dyollb deleted the patch-2 branch July 1, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action:ApplyClangFormat Add this label to a pull request to apply `clang-format` to the branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants