Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix move of histogram smart pointer #146

Conversation

blowekamp
Copy link
Member

Fixes so the a ownership transfer of the histogram pointer can occur
via std::move in the ThreadedMergeHistogram method.

Fixes so the a ownership transfer of the histogram pointer can occur
via std::move in the ThreadedMergeHistogram method.
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of these changes makes a small improvement to speed up. Eventually these items add up to something substantial!

Thanks.

@hjmjohnson hjmjohnson merged commit 61e0417 into InsightSoftwareConsortium:master Nov 7, 2018
4lexty added a commit to 4lexty/ITK that referenced this pull request Jun 25, 2020
thewtex added a commit that referenced this pull request Jun 25, 2020
DOC: fixes issue in itkSoftwareGuide #146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants