Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(convert-image): migrate to own package #739

Closed
wants to merge 1 commit into from

Conversation

floryst
Copy link
Member

@floryst floryst commented Jan 27, 2023

No description provided.

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most excellent.

convert-image -> image-io

set_property(TARGET ${target}
PROPERTY RUNTIME_OUTPUT_DIRECTORY
${WebAssemblyInterface_BINARY_DIR}/image-io
${CMAKE_CURRENT_SOURCE_DIR}/typescript/dist/image-io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image-io -> pipelines

configure_file(${CMAKE_CURRENT_SOURCE_DIR}/../../../ImageIOIndex.ts.in
${CMAKE_CURRENT_SOURCE_DIR}/../../../../../../dist/image-io/index.js @ONLY)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/ImageIOIndex.ts.in
${CMAKE_CURRENT_SOURCE_DIR}/ImageIOIndex.ts @ONLY)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> typescript/src/ImageIOIndex.ts

configure_file(${CMAKE_CURRENT_SOURCE_DIR}/ImageIOIndex.ts.in
${CMAKE_CURRENT_SOURCE_DIR}/ImageIOIndex.ts @ONLY)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/ImageIOIndex.ts.in
${CMAKE_CURRENT_SOURCE_DIR}/dist/image-io/index.js @ONLY)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this one now?

@thewtex
Copy link
Member

thewtex commented Aug 16, 2023

Superseded by #741

@thewtex thewtex closed this Aug 16, 2023
@floryst floryst deleted the migrate-convert-image-to-pkg branch August 16, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants