Launcher + S3 overhaul

.github/workflows/ci.yaml

@@ -26,6 +26,7 @@ jobs:
       - uses: bahmutov/[email protected]
         env:
           XDG_CACHE_HOME: "/home/runner/.cache/yarn"
+      - run: yarn test
       - run: yarn build
       - run: npx keycloakify
 

.sonarcloud.properties

@@ -1 +1 @@
-sonar.cpd.exclusions=/web/src/ui/i18n/resources/*
+sonar.cpd.exclusions=/web/src/ui/i18n/resources/*,**/*.test.ts

web/.env

@@ -801,6 +801,11 @@ S3_DOCUMENTATION_LINK=https://docs.sspcloud.fr/content/storage.html
 #
 VAULT_DOCUMENTATION_LINK=https://docs.sspcloud.fr/content/secrets.html
 
+# For devloppement only, to use if you want to run onyxia-web locally and connect to a remote
+# onyxia-api instance.
+# You would set for example ONYXIA_API_URL=https://datalab.sspcloud.fr/api
+ONYXIA_API_URL=/api
+
 # ==================================================================================
 # Private parameters - Not expected to be configured by the instance administrator
 # ==================================================================================
@@ -812,9 +817,6 @@ VAULT_DOCUMENTATION_LINK=https://docs.sspcloud.fr/content/secrets.html
 ONYXIA_VERSION=
 ONYXIA_VERSION_URL=
 
-# This is to be configured if you want to spin up a local instance of onyxia-web
-# and connect to a remote instance of onyxia-api.
-# You would set for example ONYXIA_API_URL=https://datalab.sspcloud.fr/api
-ONYXIA_API_URL=/api
-
 ALLOW_THEME_TESTING_VIA_URL=false
+
+SCREEN_SCALER=true

web/package.json

@@ -14,28 +14,43 @@
         "format": "yarn _format --write",
         "format:check": "yarn _format --list-different",
         "emails-domain-accept-list-helper": "tsx scripts/emails-domain-accept-list-helper.ts",
+        "test": "vitest --run",
         "storybook": "storybook dev -p 6006",
-        "build-storybook": "storybook build",
         "prestorybook": "tsx scripts/unyamlify-env-local.ts"
     },
     "dependencies": {
         "@aws-sdk/client-s3": "^3.513.0",
         "@aws-sdk/lib-storage": "^3.513.0",
         "@aws-sdk/s3-request-presigner": "^3.513.0",
+        "@babel/runtime": "7.25.6",
+        "@codemirror/autocomplete": "6.18.1",
+        "@codemirror/lang-yaml": "6.1.1",
+        "@codemirror/language": "6.10.3",
+        "@codemirror/lint": "6.8.1",
+        "@codemirror/search": "6.5.6",
+        "@codemirror/state": "6.4.1",
+        "@codemirror/theme-one-dark": "6.1.2",
+        "@codemirror/view": "6.33.0",
         "@duckdb/duckdb-wasm": "^1.13.1-dev230.0",
         "@duckdb/duckdb-wasm-shell": "^1.13.1-dev230.0",
         "@emotion/cache": "^11.11.0",
         "@emotion/react": "^11.11.3",
         "@emotion/styled": "^11.11.0",
+        "@lezer/common": "1.2.1",
+        "@lezer/highlight": "1.2.1",
+        "@mui/base": "^5.0.0-beta.58",
         "@mui/icons-material": "5.14.15",
         "@mui/material": "^5.15.10",
         "@mui/system": "^5.15.9",
         "@mui/x-data-grid": "^6.19.4",
+        "@uiw/codemirror-themes": "4.23.2",
+        "@uiw/react-codemirror": "4.23.2",
         "@ungap/structured-clone": "^1.2.0",
         "async-mutex": "^0.4.0",
         "axios": "^0.26.0",
         "bytes": "^3.1.2",
-        "clean-architecture": "^4.3.7",
+        "clean-architecture": "^4.3.8",
+        "codemirror": "6.0.1",
         "color": "^4.2.3",
         "compare-versions": "^5.0.1",
         "evt": "^2.5.7",
@@ -47,8 +62,8 @@
         "memoizee": "^0.4.15",
         "minimal-polyfills": "^2.2.3",
         "moment": "^2.29.1",
-        "oidc-spa": "^5.4.0",
-        "onyxia-ui": "^5.3.6",
+        "oidc-spa": "^5.4.3",
+        "onyxia-ui": "^5.4.0",
         "pathe": "^1.1.2",
         "powerhooks": "^1.0.12",
         "react": "^18.2.0",
@@ -108,7 +123,8 @@
         "vite": "^5.0.8",
         "vite-envs": "^4.4.5",
         "vite-plugin-commonjs": "^0.10.1",
-        "vite-tsconfig-paths": "^4.3.1"
+        "vite-tsconfig-paths": "^4.3.1",
+        "vitest": "^2.0.5"
     },
     "lint-staged": {
         "*.{ts,tsx,json,md}": [

web/src/core/adapters/oidc/index.ts

@@ -0,0 +1 @@
+export * from "./oidc";

web/src/core/adapters/oidc/mock.ts

@@ -7,10 +7,7 @@ export async function createOidc(params: {
     const { isUserInitiallyLoggedIn } = params;
 
     const oidc = await createMockOidc({
-        isUserInitiallyLoggedIn,
-        "mockedTokens": {
-            "decodedIdToken": {}
-        }
+        isUserInitiallyLoggedIn
     });
 
     return oidc;

web/src/core/adapters/oidc/utils/createOidcOrFallback.ts

@@ -1,9 +1,8 @@
 import type { Oidc } from "core/ports/Oidc";
-import { assert, type Equals } from "tsafe/assert";
+import { assert } from "tsafe/assert";
 import { noUndefined } from "tsafe/noUndefined";
 
 export async function createOidcOrFallback(params: {
-    oidcAdapterImplementationToUseIfNotFallingBack: "default";
     oidcParams:
         | {
               issuerUri?: string;
@@ -12,8 +11,7 @@ export async function createOidcOrFallback(params: {
         | undefined;
     fallbackOidc: Oidc.LoggedIn | undefined;
 }): Promise<Oidc.LoggedIn> {
-    const { oidcAdapterImplementationToUseIfNotFallingBack, oidcParams, fallbackOidc } =
-        params;
+    const { oidcParams, fallbackOidc } = params;
 
     const wrap = (() => {
         const { issuerUri, clientId } = {
@@ -47,11 +45,7 @@ export async function createOidcOrFallback(params: {
         case "oidc client":
             return wrap.oidc;
         case "oidc params": {
-            assert<
-                Equals<typeof oidcAdapterImplementationToUseIfNotFallingBack, "default">
-            >();
-
-            const { createOidc } = await import("../default");
+            const { createOidc } = await import("../oidc");
 
             const oidc = await createOidc({
                 "issuerUri": wrap.oidcParams.issuerUri,

web/src/core/adapters/onyxiaApi/default/ApiTypes.ts → web/src/core/adapters/onyxiaApi/ApiTypes.ts

@@ -1,5 +1,6 @@
 /* eslint-disable no-template-curly-in-string */
-import type { LocalizedString, JSONSchemaObject } from "core/ports/OnyxiaApi";
+import type { LocalizedString, JSONSchema } from "core/ports/OnyxiaApi";
+import type { ArrayOrNot } from "core/tools/ArrayOrNot";
 
 export type ApiTypes = {
     "/public/ip": {
@@ -83,7 +84,7 @@ export type ApiTypes = {
                 };
             };
             data?: {
-                S3?: {
+                S3?: ArrayOrNot<{
                     URL: string;
                     pathStyleAccess?: true;
 
@@ -116,7 +117,7 @@ export type ApiTypes = {
                               bucketNamePrefix: string;
                               bucketNamePrefixGroup: string;
                           };
-                };
+                }>;
             };
             vault?: {
                 URL: string;
@@ -179,23 +180,22 @@ export type ApiTypes = {
         }[];
     };
     "/public/catalogs/${catalogId}/charts/${chartName}/versions/${chartVersion}": {
-        config: JSONSchemaObject;
+        config: JSONSchema;
+        defaultValues: string;
         sources?: string[];
         dependencies?: {
             name: string;
             repository: string;
             version: string;
+            condition?: string;
         }[];
     };
     "/my-lab/services": {
         apps: {
             id: string;
             status: "deployed" | "pending-install" | "failed";
             urls: string[];
-            env: {
-                // Actually Record<string, string> but we prefer only listing known properties
-                // for type safety.
-            };
+            env: Record<string, string>;
             owner: string;
             startedAt: number;
             tasks: {