Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Add L1 fee to transaction fee for receipts #110

Merged
merged 2 commits into from
Apr 16, 2024
Merged

[fix] Add L1 fee to transaction fee for receipts #110

merged 2 commits into from
Apr 16, 2024

Conversation

tobidae-cb
Copy link
Contributor

In this PR

  1. Use a custom L2 Receipt that matches the specs defined in here

Updating the L2GethType call everywhere will require an overhaul to how transactions are constructed and data compiled. I attempted to but had to roll it back afterwards.

@tobidae-cb tobidae-cb closed this Apr 10, 2024
@tobidae-cb tobidae-cb reopened this Apr 10, 2024
Inphi
Inphi reviewed Apr 15, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
optimism/types.go Show resolved Hide resolved
@tobidae-cb tobidae-cb requested a review from Inphi April 16, 2024 18:02
Inphi
Inphi approved these changes Apr 16, 2024
View reviewed changes
Copy link
Owner

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Inphi Inphi merged commit 565925e into Inphi:master Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inphi Inphi Inphi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobidae-cb @Inphi