Switch to pull_request_target strategy #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkoppert
requested review from
lenucksi,
NewMexicoKid,
cewilliams,
spier,
robtuley and
yuhattor
as code owners
spier
approved these changes
Oct 31, 2023
|
Thank you @zkoppert. This PR is merged. Could you also create PR from your fork, to test if this works? |
|
I forgot that I can push changes to a PR submitted from a fork myself. Just did that. However it looks like the workflow is still failing. See: |
rmarting
pushed a commit
to rmarting/InnerSourcePatterns
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #581
This changes from running the gitbook workflow on the upstream repo to actually running it on the fork that a contributor has created with a changeset. The hope is that this will address the failing builds described in #581 . In order to test this change I believe we need to merge this through to the main branch and then open a pull request from a fork which would trigger this github action job.
cc/ @spier