Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(zpool): "see" line in status is not parsed correctly #168

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

s-burris
Copy link
Contributor

I discovered while using libzetta with OpenZFS that "see: https://[url]" in any pool's status prevents libzetta from seeing all the pools on a system. I've made a very small change to the grammar file that fixes this, as well as a test that https urls are parsed correctly (test with http url already present and confirmed to still work).

Additionally, this "see: [url]" line appears before the scan line in both OpenZFS, Solaris ZFS, and FreeBSD ZFS, so I have changed the order to reflect this and prevent issues when both are present.

References where you can see the ordering:

  pool: P06
 state: DEGRADED
status: One or more devices could not be used because the label is missing or
        invalid.  Sufficient replicas exist for the pool to continue
        functioning in a degraded state.
action: Replace the device using 'zpool replace'.
   see: https://openzfs.github.io/openzfs-docs/msg/ZFS-8000-4J
  scan: resilvered 36K in 00:00:00 with 0 errors on Thu Apr 14 10:05:16 2022
config:

        NAME                                        STATE     READ WRITE CKSUM
        P06                                         DEGRADED     0     0     0
          mirror-0                                  DEGRADED     0     0     0
            wwn-0x6000c29f4c9905611811212855b62142  ONLINE       0     0     0
            wwn-0x6000c2960c24392266c762344a8efda7  UNAVAIL      3   123     0

By the way, the 0.2.3 tag is missing a release on Github.

@andoriyu andoriyu changed the title Fix parsing with https urls in status output fix:(zpool): "see" line in status is not parsed correctly Apr 14, 2022
@andoriyu andoriyu merged commit b15d168 into Inner-Heaven:master Apr 14, 2022
@andoriyu
Copy link
Member

@s-burris Looks good. I will try to dedicate some time to this crate this weekend to fix changelog/tags and do a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants