fix:(zpool): "see" line in status is not parsed correctly #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered while using libzetta with OpenZFS that "see: https://[url]" in any pool's status prevents libzetta from seeing all the pools on a system. I've made a very small change to the grammar file that fixes this, as well as a test that https urls are parsed correctly (test with http url already present and confirmed to still work).
Additionally, this "see: [url]" line appears before the scan line in both OpenZFS, Solaris ZFS, and FreeBSD ZFS, so I have changed the order to reflect this and prevent issues when both are present.
References where you can see the ordering:
zpool status
on an OpenZFS machine:By the way, the 0.2.3 tag is missing a release on Github.