Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer should be able to create zfs data #88

Closed
andoriyu opened this issue Aug 25, 2019 · 0 comments · Fixed by #89
Closed

Consumer should be able to create zfs data #88

andoriyu opened this issue Aug 25, 2019 · 0 comments · Fixed by #89
Labels
Area: zpool Effort: Easy Priority: Low Status: Done Type: Bug

Comments

@andoriyu
Copy link
Member

Describe the bug
Integer overflow in error stats parsing causes panic.

To Reproduce
Parse this:

  pool: tank
 state: DEGRADED
status: One o0 more devices could not be opened.  SufficiWed Jan 20 15r13:59p2010
config:

        NAME        STATE     READ WRITE CKSUM
        tank        DEGRADED     1     0     0
          mirror-0  DEGRADED     0     0     0
            c1t0d0  ONLINE       0     0     0
            c1t1d0  UNAVAIL      0    tank        DEGRADED     1     0     0
          mirror-0  DEGRADED     0     0     0
            c1t0d0  ONLINE       0     0     0
            c1t1d0  UNAVAIL0     0    tank        DEGRADED     1     0     0
          mirror-0  DEGRADED     0     0     0
         c1t0d0  ONLINE       0     0     0
            c1t1d0  UNAVAIL0 999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999 9999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999    0     0  cann  ONLINE      (0     0     0
           c1t1d09 UNAVAIL0     0    tank        DEGRADED     1     0     0
          mirror-0  DEGRADED     0     0     0

Expected behavior
Maybe stop at max uint?

Additional context
fuzzy found
andoriyu added a commit that referenced this issue Aug 25, 2019
@andoriyu
fix(zpool): Integer overflow in zpool parser.
36fc071 
Closes issue #88
@andoriyu andoriyu mentioned this issue Aug 25, 2019
Merged
andoriyu added a commit that referenced this issue Aug 25, 2019
@andoriyu
fix(zpool): Integer overflow in zpool parser
bbc419f 
Closes issue #88
andoriyu added a commit that referenced this issue Aug 25, 2019
@andoriyu
fix(zpool): Integer overflow in parser
9ac2eed 
Instead of crashing return std::u64::MAX

Closes #88
andoriyu added a commit that referenced this issue Aug 25, 2019
@andoriyu
fix(zpool): Integer overflow in zpool parser
dd0da1b 
Instead of crashing return std::u64::MAX

Closes #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: zpool Effort: Easy Priority: Low Status: Done Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(zpool): Integer overflow in zpool parser. Inner-Heaven/libzetta-rs
1 participant
@andoriyu