Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test easy_snapshot_and_bookmark is failing #159

Closed
andoriyu opened this issue Oct 27, 2021 · 2 comments · Fixed by #170
Closed

Test easy_snapshot_and_bookmark is failing #159

andoriyu opened this issue Oct 27, 2021 · 2 comments · Fixed by #170
Labels
Area: zfs good-first-issue Priority: Medium Type: Bug

Comments

@andoriyu
Copy link
Member

Current master has a failing test:

    ☓ easy_snapshot_and_bookmark
        thread 'easy_snapshot_and_bookmark' panicked at 'called `Result::unwrap()` on an `Err` value: Io(Os { code: 1032, kind: Uncategorized, message: "Unknown error 1032" })', tests/test_zfs.rs:287:48
        note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Need to:

  • Map error code to a proper error
  • Fix code so test passes
@andoriyu
Copy link
Member Author

No idea why it's happening. I want to change Io error to Errno crate instead. There is a chance the source of the error is timing.

@andoriyu andoriyu mentioned this issue Apr 17, 2022
Merged
@andoriyu
Copy link
Member Author

Alright, 1032 defined here: https://github.com/openzfs/zfs/blob/master/include/sys/fs/zfs.h#L1510-L1533

It's ZFS_ERR_IOC_ARG_BAD_TYPE

andoriyu added a commit that referenced this issue Apr 17, 2022
@andoriyu
fix(zfs): Fix destroy_bookmarks method
284326b 
Issue was wrong type. Turns out boolean and boolean_value are not
the same thing.

Closes #159
andoriyu added a commit that referenced this issue Apr 17, 2022
@andoriyu
fix(zfs): Fix destroy_bookmarks method
676fede 
Issue was wrong type. Turns out boolean and boolean_value are not
the same thing.

Closes #159
@andoriyu andoriyu mentioned this issue Apr 17, 2022
Merged
andoriyu added a commit that referenced this issue Apr 17, 2022
@andoriyu
fix(zfs): Fix destroy_bookmarks method (#170)
755e2cd 
Issue was wrong type. Turns out boolean and boolean_value are not
the same thing.

Closes #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: zfs good-first-issue Priority: Medium Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(zfs): Fix destroy_bookmarks method Inner-Heaven/libzetta-rs
1 participant
@andoriyu