update index.php to eliminate deprecation warning for PHP 8.2 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the deprecation warning for PHP 8.2
update index.php
Zegnat
requested changes
Oct 29, 2023
There was a problem hiding this comment.
Note that selfauth is compatible with PHP 5.6. I am not sure we are currently thinking of dropping that backwards compatibility because of the earlier audience for this project.
The null coalescing operator used in this PR was first introduced in PHP 7.0. Could we use a PHP 5.6 compatible solution instead?
| @@ -132,7 +132,7 @@ function get_q_value($mime, $accept) | |||
|
|
|||
| function base64_url_encode($string) | |||
| { | |||
| $string = base64_encode($string); | |||
| $string = base64_encode($string ?? ''); | |||
There was a problem hiding this comment.
Suggested change
| $string = base64_encode($string ?? ''); | |
| $string = base64_encode(isset($string) ? $string : ""); |
There was a problem hiding this comment.
I never saw this comment, oops! I have moved off my indieweb/selfauth project for a bit, but should hopefully be back to it soon and I can revisit this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #50 (comment)