Skip to content

Commit

Permalink
Revert "Save gas on IsFeeEnabled (backport cosmos#2786) (cosmos#2815)"
Browse files Browse the repository at this point in the history
This reverts commit 4bb451c.
  • Loading branch information
colin-axner authored and albertchon committed May 25, 2023
1 parent 845bec9 commit d1590b5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Improvements

* (apps/29-fee) [\#2786](https://github.com/cosmos/ibc-go/pull/2786) Save gas by checking key existence with `KVStore`'s `Has` method.
### Features

### Bug Fixes

Expand Down
2 changes: 1 addition & 1 deletion modules/apps/29-fee/keeper/keeper.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (k Keeper) DeleteFeeEnabled(ctx sdk.Context, portID, channelID string) {
// fee enabled flag for the given port and channel identifiers
func (k Keeper) IsFeeEnabled(ctx sdk.Context, portID, channelID string) bool {
store := ctx.KVStore(k.storeKey)
return store.Has(types.KeyFeeEnabled(portID, channelID))
return store.Get(types.KeyFeeEnabled(portID, channelID)) != nil
}

// GetAllFeeEnabledChannels returns a list of all ics29 enabled channels containing portID & channelID that are stored in state
Expand Down

0 comments on commit d1590b5

Please sign in to comment.