feat: 🎸 attempts to fix travis bug

Inist-CNRS · Jul 16, 2020 · 6f31157 · 6f31157
1 parent 9d87a1c
commit 6f31157
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 3 deletions.
diff --git a/packages/analytics/src/expand.js b/packages/analytics/src/expand.js
@@ -69,18 +69,20 @@ export default async function expand(data, feed) {
         const output = ezs.createPipeline(this.input, statements)
             .pipe(ezs.catch())
             .on('data', async ({ id, value }) => {
-                const obj = await this.store.get(id);
-                if (obj) {
+                try {
+                    const obj = await this.store.get(id);
                     set(obj, path, value);
                     feed.write(obj);
+                } catch (e) {
+                    feed.stop(e);
                 }
             })
             .on('error', (e) => feed.stop(e));
         whenFinish = new Promise((resolve) => output.on('end', resolve));
     }
     if (this.isLast()) {
         return whenFinish
-            .then(async () => {
+            .then(() => {
                 this.store.close();
                 return feed.close();
             })

diff --git a/packages/analytics/test/expand.js b/packages/analytics/test/expand.js
@@ -203,4 +203,32 @@ describe('no expand', () => {
                 done();
             });
     });
+    test('with a script that loses the identifier', (done) => {
+        const input = [
+            { a: 1, b: 'a' },
+            { a: 2, b: 'b' },
+            { a: 3, b: 'c' },
+            { a: 4, b: 'd' },
+            { a: 5, b: 'e' },
+            { a: 6, b: 'f' },
+        ];
+        const script = `
+            [use]
+            plugin = analytics
+
+            [replace]
+            path = value
+            value = get('value').toUpper()
+        `;
+
+        from(input)
+            .pipe(ezs('expand', { path: 'b', script }))
+            .pipe(ezs.catch())
+            .on('error', () => {
+                done();
+            })
+            .on('end', () => {
+                done(new Error('Error is the right behavior'));
+            });
+    });
 });