fix data and _ mismatch line 169

[docNord]

Closes #89

[mgcth]

How do you call

ifk-smhi/src/smhi/smhi.py

Line 131 in 403f521

def get_data(

to provoke the error reported in #89?

I can only manage to provoke another error from some non-thorough testing

c.get_data(2, 6057, interpolate=0)

[docNord]

How do you call

ifk-smhi/src/smhi/smhi.py

Line 131 in 403f521

def get_data(

to provoke the error reported in #89?

I can only manage to provoke another error from some non-thorough testing

c.get_data(2, 6057, interpolate=0)

Hmm, that is odd. I now get an error from MetObs when calling any station. MetObs is complaining that "Datum" is not included in the output from the SMHI API.
I dowloaded a file manually to see if the format has changed somehow, but that does not seem to be the case. Any ideas on what is going on @mgcth ?

[docNord]

Update:
It seems there is a different return format specifically for parameter 2 @mgcth . I propose that you approve this PR and then we open a new issue to solve that problem. You should be able to recreate the issue reported with this code:

from smhi import smhi
s=smhi.SMHI()
data, _ = s.get_data(8,180960,interpolate=40)

[mgcth]

I'd like to reproduce the error here before I approve. How should I call get_data to reproduce the issue in #89 which you are fixing here?

[docNord]

Did you try the snippet in my previous comment @mgcth ?

[mgcth]

Sorry, missed it. Do we have tests for this function? Looks like we don't. I'm thinking, it's probably a good time to add a unit test for it here. Though, the function is somewhat complex and could be refactored.

[mgcth]

I'll approve it now, looks correct. A refactor and tests would be nice.