Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/extraction script #34

Merged
merged 25 commits into from
Jun 6, 2024
Merged

Feature/extraction script #34

merged 25 commits into from
Jun 6, 2024

Conversation

@mgcth mgcth self-assigned this Apr 28, 2024
@mgcth mgcth force-pushed the feature/extraction-script branch from 922d120 to 53277d2 Compare May 2, 2024 14:47
@mgcth mgcth marked this pull request as ready for review May 4, 2024 21:17
@mgcth mgcth requested review from docNord and strobba May 4, 2024 21:17
Copy link

@strobba strobba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I could have spent more time on the review, however this is it for now. See attached comments.

src/lantmateriet/api.py Outdated Show resolved Hide resolved
src/lantmateriet/api.py Outdated Show resolved Hide resolved
src/lantmateriet/api.py Show resolved Hide resolved
src/lantmateriet/api.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
src/lantmateriet/extract.py Show resolved Hide resolved
src/lantmateriet/point.py Show resolved Hide resolved
src/lantmateriet/utils.py Show resolved Hide resolved
src/lantmateriet/geometry.py Show resolved Hide resolved
tests/unit/test_unit_line.py Show resolved Hide resolved
@mgcth
Copy link
Contributor Author

mgcth commented May 12, 2024

@strobba
Copy link

strobba commented May 13, 2024

It seems like ray is not supported in 3.12

https://discuss.ray.io/t/install-ray-on-python-3-12-2/14438

@mgcth mgcth force-pushed the feature/extraction-script branch from 47f5097 to ccf97ad Compare May 28, 2024 20:16
@mgcth mgcth requested a review from strobba June 3, 2024 15:01
@mgcth mgcth merged commit c509ac4 into main Jun 6, 2024
9 checks passed
@mgcth mgcth deleted the feature/extraction-script branch June 6, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment