-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search function implemented. #3
search function implemented. #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
The docstring is no longer correct as the function is no longer slow with the stored index, should be updated.
( there are tests which haven't been fulfilled yet)
Doc string removed. I'll fix linting. However, @mgcth why didn't my local ruff catch these things? Edit: Aha, ruff has no type checker. It is mypy who check the types... |
@mgcth considering the gist badge that fails in the test, where do I find it and how do i correct it? |
You find it here #4 and needed to rebase/merge main into here. |
Ah, so it was the same issue again. Thanks @mgcth 🙌😊 |
21285b7
into
integrate-and-structure-current-code
I felt a need for a method to search scb data from python, hence I implemented a search function. However, there is a request limit at scb which forced me to slow down the search. So by now its kind of slow. I raised an issue, with a potential solution to this. For now, the search can be slow imo.