Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add sorting to elastic #279

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Feat/add sorting to elastic #279

merged 3 commits into from
Oct 6, 2023

Conversation

hegeaal
Copy link
Contributor

@hegeaal hegeaal commented Oct 4, 2023

closes #277

@hegeaal hegeaal requested a review from a team October 4, 2023 12:14
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #279 (a20036d) into main (9952701) will increase coverage by 0.73%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #279      +/-   ##
============================================
+ Coverage     81.85%   82.59%   +0.73%     
- Complexity      444      453       +9     
============================================
  Files            51       51              
  Lines          1571     1580       +9     
  Branches        237      239       +2     
============================================
+ Hits           1286     1305      +19     
+ Misses          146      139       -7     
+ Partials        139      136       -3     
Files Coverage Δ
...dk/concept_catalog/service/ConceptSearchService.kt 95.74% <100.00%> (+1.00%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@NilsOveTen NilsOveTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

men må fikse konflikter

@hegeaal hegeaal force-pushed the feat/add-sorting-to-elastic branch 5 times, most recently from f60bfad to 0c760cb Compare October 6, 2023 08:34
@hegeaal hegeaal force-pushed the feat/add-sorting-to-elastic branch from 0a969ab to a20036d Compare October 6, 2023 10:28
@hegeaal hegeaal merged commit a493aab into main Oct 6, 2023
@hegeaal hegeaal deleted the feat/add-sorting-to-elastic branch October 6, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic: Sortering
3 participants