fix: Pictures no longer on device but only on iCloud should be uploaded as well. #1339

adrien-coye · 2024-11-08T12:21:16Z

Correct error handling during the hashing of a photo source.
Sending an event to sentry if an error is raised when we try to fetch an asset that might only be available remotely on iCloud.

I do not skip assets that we are unable to access, as this could result in a loss of data for the consumer.

…to Sentry to create a dashboard.

sonarcloud · 2024-11-08T13:21:23Z

Quality Gate passed

kDriveCore/Utils/PHAsset/PHAssetIdentifier.swift

fix: Correct error handling during the hashing of a photo source

c41de10

adrien-coye marked this pull request as draft November 8, 2024 12:21

feat: PHAssetResourceManager errors while fetching an asset are sent …

c72428a

…to Sentry to create a dashboard.

adrien-coye requested a review from valentinperignon November 8, 2024 13:27

adrien-coye commented Nov 8, 2024

View reviewed changes

kDriveCore/Utils/PHAsset/PHAssetIdentifier.swift Show resolved Hide resolved

adrien-coye self-assigned this Nov 8, 2024

adrien-coye marked this pull request as ready for review November 8, 2024 13:29

adrien-coye added the bug Something isn't working label Nov 8, 2024

adrien-coye added this to the 5.0.2 milestone Nov 8, 2024

valentinperignon approved these changes Nov 13, 2024

View reviewed changes

adrien-coye merged commit 33bcf74 into master Nov 14, 2024
7 checks passed

adrien-coye deleted the fix-photo-sync-iCloud-offload branch November 14, 2024 08:05