Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cache cleanup fix #1337

Merged
merged 9 commits into from
Nov 7, 2024
Merged

fix: Cache cleanup fix #1337

merged 9 commits into from
Nov 7, 2024

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Nov 6, 2024

  • Each chunk is now cleaned right away after a successful upload. In some heavy system load conditions, the clean-up was not performed.
  • The clean-up of the cache folder is triggered earlier on
  • The cleanup is not only done when the app closes, but now also before we try to rebuild the upload queue

@adrien-coye adrien-coye added this to the 5.0.2 milestone Nov 6, 2024
@adrien-coye adrien-coye added the bug Something isn't working label Nov 6, 2024
@adrien-coye adrien-coye marked this pull request as ready for review November 6, 2024 12:56
@adrien-coye adrien-coye changed the title fix: Upload chunks cleanup right away fix: Cache cleanup fix Nov 6, 2024
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments for reviewer.

Copy link

sonarcloud bot commented Nov 7, 2024

@adrien-coye adrien-coye merged commit e12c9ed into master Nov 7, 2024
5 checks passed
@adrien-coye adrien-coye deleted the temp_automatic_clean branch November 7, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants