feat: Add now playing info for video #1324
Conversation
Matthieu-dgl
changed the title
Matthieu-dgl
force-pushed
the
feat-add-now-playing-info-for-video
branch
3 times, most recently
from
696ce86
to
c92cac3
Compare
Matthieu-dgl
force-pushed
the
feat-add-now-playing-info-for-video
branch
from
915becc
to
5a6c505
Compare
Matthieu-dgl
force-pushed
the
feat-add-now-playing-info-for-video
branch
from
5a6c505
to
b2e12e0
Compare
There was a problem hiding this comment.
You only observe .AVPlayerItemDidPlayToEndTime.
This only set the correct metadata at the end of the track.
Maybe try to also remove MPMediaItemPropertyPlaybackDuration and MPNowPlayingInfoPropertyElapsedPlaybackTime because they should be set by the VideoPlayer
Matthieu-dgl
force-pushed
the
feat-add-now-playing-info-for-video
branch
2 times, most recently
from
ba1c29c
to
0181d06
Compare
|
There's always the problem that the video title appears for 1 second and then disappears in the notfication. I'm open to an idea! |
Matthieu-dgl
force-pushed
the
feat-add-now-playing-info-for-video
branch
from
1d83e16
to
a4fb80a
Compare
| import MediaPlayer | ||
| import UIKit | ||
|
|
||
| class VideoPlayer { |
There was a problem hiding this comment.
Since VideoPlayer is now in Core you need to make it a public type.
You could build a protocol with all the public properties you want to use from the outside.
| } | ||
|
|
||
| @IBAction func playVideoPressed(_ sender: Any) { | ||
| guard let player else { return } | ||
| guard let player = videoPlayer?.avPlayer else { |
There was a problem hiding this comment.
I'm not found of exposing directly the AVPlayer in the cell.
It goes against encapsulation, I would rather use a mechanism for decoupling (like Combine in the SingleTrackPlayer)
There was a problem hiding this comment.
Discussed, you can use this in VideoPlayer to remove the property avPlayer
public lazy var playerViewController: AVPlayerViewController = {
let playerViewController = AVPlayerViewController()
playerViewController.player = self.player
return playerViewController
}()| } | ||
| } | ||
|
|
||
| private func presentVideoPlayer(navController: VideoPlayerNavigationController, |
There was a problem hiding this comment.
It looks like it is an unused method. Should we remove it ?
|
As a "nice to have", we could also set a thumbnail. We already have one, it should be straight forward. |
| return player.currentTime().seconds / currentItem.duration.seconds | ||
| } | ||
|
|
||
| init(file: File, driveFileManager: DriveFileManager) { |
There was a problem hiding this comment.
| init(file: File, driveFileManager: DriveFileManager) { | |
| init(frozenFile: File, driveFileManager: DriveFileManager) { |
It looks like we use a frozenFile, therefore you can rename the parameter.
Matthieu-dgl
force-pushed
the
feat-add-now-playing-info-for-video
branch
from
1c00484
to
3bd12ae
Compare
|
No description provided.