feat: Sync of photos wifiOnly #1313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adrien-coye
force-pushed
the
Link-back-with-front
branch
from
f05c24b
to
e5219ab
Compare
|
adrien-coye
requested changes
Nov 14, 2024
|
|
||
| class OfflineSyncSettingsViewController: BaseGroupedTableViewController { | ||
| private var tableContent: [SyncMode] = SyncMode.allCases | ||
| private var selectedOfflineMod: SyncMode! |
There was a problem hiding this comment.
We really should not use force unwrap. You could provide a default value for instance or make it lazy / computed property to make it work.
| } | ||
|
|
||
| override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) { | ||
| let mod = tableContent[indexPath.row] |
| @@ -66,19 +64,18 @@ class WifiSyncSettingsViewController: BaseGroupedTableViewController { | |||
| override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell { | |||
| let cell = tableView.dequeueReusableCell(type: ParameterSyncTableViewCell.self, for: indexPath) | |||
| cell.initWithPositionAndShadow(isFirst: true, isLast: true) | |||
| let currentMode = tableContent[indexPath.row] | |||
| if currentMode == selectedMode { | |||
| let currentMod = tableContent[indexPath.row] | |||
| let mode = tableContent[indexPath.row] | ||
| MatomoUtils.track(eventWithCategory: .settings, name: "mode\(mode.rawValue.capitalized)") | ||
| UserDefaults.shared.syncMode = mode | ||
| let mod = tableContent[indexPath.row] |
| @@ -338,16 +338,16 @@ public extension UserDefaults { | |||
| } | |||
| } | |||
|
|
|||
| var syncMode: SyncMode { | |||
| var syncOfflineMod: SyncMode { | |||
| @@ -56,4 +57,22 @@ extension UploadOperation { | |||
| file.pathURL = url | |||
| } | |||
| } | |||
|
|
|||
| func checkForRestrictedUploadOverDataMode() throws { | |||
There was a problem hiding this comment.
I'm not found of this, can we keep it in UploadQueue ? We do not want to put each upload in error, do we ?
The behaviour until now was the upload queue would not start. We need to discuss this together at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature PR here #1310