Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI run all tests #1230

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

fix: CI run all tests #1230

wants to merge 31 commits into from

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Jul 23, 2024

edit: I'll need to restart this PR as soon as the Tuist issues are fixed.

Also bump libraries

@adrien-coye adrien-coye added this to the 5.0.0 milestone Jul 23, 2024
@adrien-coye adrien-coye changed the title chore: Bump libraries fix CI run tests with tuist 4 Jul 23, 2024
@adrien-coye adrien-coye changed the title fix CI run tests with tuist 4 fix: CI run tests with tuist 4 Jul 23, 2024
@adrien-coye adrien-coye force-pushed the bump_dependency_ branch 6 times, most recently from 22f660e to 476d0df Compare July 24, 2024 11:57
@adrien-coye adrien-coye changed the title fix: CI run tests with tuist 4 fix: CI run all tests Jul 24, 2024
@adrien-coye adrien-coye force-pushed the bump_dependency_ branch 2 times, most recently from 5413990 to 9cf93bd Compare July 31, 2024 09:05
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listing commented tests, see what can be re-eanbled quickly.

try await checkIfFileIsInDestination(file: file, directory: directory)
tearDownTest(directory: testDirectory)
}
/* FIXME: Timeout
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME

}
*/

/* FIXME: Timeout
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME

XCTAssertTrue(fileFound, "File created should be in response")
tearDownTest(directory: testDirectory)
}
/* FIXME: File created should be in response
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME

kDriveAPITests/kDriveCore/DriveFileManagerTests.swift Outdated Show resolved Hide resolved
kDriveTests/kDrive/Launch/ITAppLaunchTest.swift Outdated Show resolved Hide resolved
kDriveTests/kDrive/Launch/UTRootViewControllerState.swift Outdated Show resolved Hide resolved
kDriveTests/kDriveCore/Drive/ITDrive.swift Outdated Show resolved Hide resolved
tearDownTest(directoryName: root)
}
}
/* FIXME: Failed to tap "x" Button: No matches found for Descendants matching type TabBar from input
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME

@adrien-coye adrien-coye force-pushed the bump_dependency_ branch 2 times, most recently from d8d1eb0 to 1cf9fea Compare August 20, 2024 09:51
…ure DI within some tests is passing (casting of factories)
…herited parameter

test(testGetFileActivities): Removed deprecated file_restore_inherited parameter
Copy link
Contributor Author

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes API actions

@@ -29,9 +29,7 @@ public enum FileActivityType: String, Codable, CaseIterable {
case fileMoveIn = "file_move"
case fileMoveOut = "file_move_out"
case fileTrash = "file_trash"
case fileTrashInherited = "file_trash_inherited"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to be removed to pass API validation

case fileRestore = "file_restore"
case fileRestoreInherited = "file_restore_inherited"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to be removed to pass API validation

@@ -67,7 +65,6 @@ public enum FileActivityType: String, Codable, CaseIterable {
.fileMoveIn,
.fileMoveOut,
.fileTrash,
.fileTrashInherited,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to be removed to pass API validation

Copy link

sonarcloud bot commented Aug 28, 2024

@adrien-coye adrien-coye modified the milestones: 5.0.0, 5.0.2 Nov 8, 2024
@adrien-coye adrien-coye added the bug Something isn't working label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants