-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CI run all tests #1230
base: master
Are you sure you want to change the base?
fix: CI run all tests #1230
Conversation
22f660e
to
476d0df
Compare
2390d9a
to
954c919
Compare
5413990
to
9cf93bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Listing commented tests, see what can be re-eanbled quickly.
try await checkIfFileIsInDestination(file: file, directory: directory) | ||
tearDownTest(directory: testDirectory) | ||
} | ||
/* FIXME: Timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME
} | ||
*/ | ||
|
||
/* FIXME: Timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME
XCTAssertTrue(fileFound, "File created should be in response") | ||
tearDownTest(directory: testDirectory) | ||
} | ||
/* FIXME: File created should be in response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME
tearDownTest(directoryName: root) | ||
} | ||
} | ||
/* FIXME: Failed to tap "x" Button: No matches found for Descendants matching type TabBar from input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME
This reverts commit a9fd881.
Signed-off-by: Philippe Weidmann <[email protected]>
…t Tuist configuration
Signed-off-by: Philippe Weidmann <[email protected]>
Signed-off-by: Philippe Weidmann <[email protected]>
c0aaa69
to
6611e12
Compare
Signed-off-by: Philippe Weidmann <[email protected]>
Signed-off-by: Philippe Weidmann <[email protected]>
4f2def6
to
ed372e5
Compare
Signed-off-by: Philippe Weidmann <[email protected]>
Signed-off-by: Philippe Weidmann <[email protected]>
Signed-off-by: Philippe Weidmann <[email protected]>
d8d1eb0
to
1cf9fea
Compare
1cf9fea
to
57084ce
Compare
…ure DI within some tests is passing (casting of factories)
…herited parameter test(testGetFileActivities): Removed deprecated file_restore_inherited parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes API actions
@@ -29,9 +29,7 @@ public enum FileActivityType: String, Codable, CaseIterable { | |||
case fileMoveIn = "file_move" | |||
case fileMoveOut = "file_move_out" | |||
case fileTrash = "file_trash" | |||
case fileTrashInherited = "file_trash_inherited" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to be removed to pass API validation
case fileRestore = "file_restore" | ||
case fileRestoreInherited = "file_restore_inherited" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to be removed to pass API validation
@@ -67,7 +65,6 @@ public enum FileActivityType: String, Codable, CaseIterable { | |||
.fileMoveIn, | |||
.fileMoveOut, | |||
.fileTrash, | |||
.fileTrashInherited, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to be removed to pass API validation
…d file_trash_inherited parameter" This reverts commit 0d39e2c.
Quality Gate passedIssues Measures |
edit: I'll need to restart this PR as soon as the
Tuist
issues are fixed.Also bump libraries