Don't show the contact if the email is incorrect #2087
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasBourdin88
added
bug
NicolasBourdin88
force-pushed
the
fix-add-email-with-illegal-name
branch
from
ba24b6e
to
1fe76a6
Compare
NicolasBourdin88
force-pushed
the
fix-add-email-with-illegal-name
branch
from
cf2c231
to
c3c480f
Compare
|
LunarX
requested changes
Nov 5, 2024
| @@ -380,7 +381,7 @@ class RecipientFieldView @JvmOverloads constructor( | |||
| fun initRecipients(initialRecipients: List<Recipient>, otherFieldsAreAllEmpty: Boolean = true) { | |||
|
|
|||
| initialRecipients.forEach { recipient -> | |||
| if (contactChipAdapter.addChip(recipient)) contactAdapter.addUsedContact(recipient.email) | |||
| addRecipient(recipient.email, recipient.name) | |||
There was a problem hiding this comment.
I just realized that this breaks the externals signalization of chips. Flagging recipients as "manuallyEntered" should be less error prone to avoid this kind of bugs.
In situations like this where split code is merged as one, you should always try and follow all of the logic from the very start of the code execution up to the very end. You'd need to understand precisely what differs in both ways of doing so you can be certain that it is safe to merge the two logics. This one was pretty hard to detect though if you didn't know about external recipients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow the user to add a contact with an invalid email, and set only one entry as 'ContactChipAdapter' for easier management.