Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FastScrollbar in Gallery #743

Merged
merged 25 commits into from
Apr 14, 2022
Merged

Add FastScrollbar in Gallery #743

merged 25 commits into from
Apr 14, 2022

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Apr 8, 2022

Closes #494

@LunarX LunarX added this to the 4.1.4 milestone Apr 8, 2022
@LunarX LunarX self-assigned this Apr 8, 2022
@LunarX LunarX requested a review from a team as a code owner April 8, 2022 09:27
@KevinBoulongne KevinBoulongne changed the title Added fast scrollbar to gallery Add FastScrollbar in Gallery Apr 12, 2022
@LunarX @JorisBodin
Adding scrollbar in gallery
2c0c418
@LunarX @JorisBodin
Finished fixing the scrollbar trackbar 'height' in home
cf59154
@LunarX @JorisBodin
Fix swipeRefresh in home picture tab
5940361
@LunarX @JorisBodin
Fix invisible statusbar in viewpager2
3242194
@LunarX @JorisBodin
Temporary styling
38444ec
@LunarX @JorisBodin
Handle now doesn't hide if we maintain the finger on the scrollbar
605b53e
@LunarX @JorisBodin
Fixed handle being misplaced placed at the top of screen
9b2acb8 
Happened when reattaching the view after being detached
@LunarX @JorisBodin
tweaking handle design
63b10b1
@LunarX @JorisBodin
Included library files directly in our own project
869f8ed
@LunarX @JorisBodin
Disable possibility to click anywhere on the scrollbar to scroll
c916dff
@LunarX @JorisBodin
Scrollbar handle icon's color uses correct value
98aac82
@LunarX @JorisBodin
Added drop shadow to scrollbar handle
b77d3c6
@LunarX @JorisBodin
Changed animation of the scrollbar handle to match new design
4c76e64
@LunarX @JorisBodin
Fixed being able to click on handle position when scrollbar is closed
da56147
@LunarX @JorisBodin
Cleaned code
55aab8c
@LunarX @JorisBodin
Fix missing month popup
a655fb4
@LunarX @JorisBodin
Cleaned xml layouts
8859d7b
@LunarX @JorisBodin
Cleaned code and removed useless code
6b554de
@LunarX @JorisBodin
Corrected comment
05ecb85
@LunarX @JorisBodin
Removed commented code
349f76d
@LunarX @JorisBodin
Cleaned code
77a5f22
@LunarX @JorisBodin
Fixed invisible handle when clicking it as it is disapearing
3a8ccd3
@LunarX @JorisBodin
Fixed spamming clicks on handle makes the month popup disappear
387437e
@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JorisBodin JorisBodin merged commit f19cc0f into master Apr 14, 2022
@JorisBodin JorisBodin deleted the gallery-scrollbar branch April 14, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorisBodin JorisBodin JorisBodin approved these changes

@KevinBoulongne KevinBoulongne KevinBoulongne approved these changes

Assignees

@LunarX LunarX

Labels
None yet
Projects
None yet
Milestone
4.1.4
Development

Successfully merging this pull request may close these issues.

FastScrollbar in Gallery
3 participants
@LunarX @KevinBoulongne @JorisBodin