Fix MultiSelect download outside of default FileList #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
force-pushed
the
Multi-select-everywhere
branch
from
0f0379e
to
9c03173
Compare
KevinBoulongne
force-pushed
the
Fix-MultiSelect-download
branch
from
488e6a4
to
f1453eb
Compare
KevinBoulongne
force-pushed
the
Multi-select-everywhere
branch
from
9c03173
to
1666345
Compare
KevinBoulongne
force-pushed
the
Fix-MultiSelect-download
branch
from
f1453eb
to
95256ab
Compare
KevinBoulongne
force-pushed
the
Multi-select-everywhere
branch
from
1666345
to
ce21e50
Compare
KevinBoulongne
changed the title
KevinBoulongne
force-pushed
the
Fix-MultiSelect-download
branch
from
95256ab
to
55e956f
Compare
JorisBodin
force-pushed
the
Fix-MultiSelect-download
branch
from
55e956f
to
2fbf5e9
Compare
JorisBodin
force-pushed
the
Multi-select-everywhere
branch
from
39b32f3
to
72946f9
Compare
JorisBodin
force-pushed
the
Fix-MultiSelect-download
branch
from
2fbf5e9
to
c382e00
Compare
KevinBoulongne
force-pushed
the
Multi-select-everywhere
branch
from
72946f9
to
70fce56
Compare
KevinBoulongne
force-pushed
the
Fix-MultiSelect-download
branch
from
c382e00
to
a9672e3
Compare
KevinBoulongne
force-pushed
the
Multi-select-everywhere
branch
from
70fce56
to
30470e5
Compare
KevinBoulongne
force-pushed
the
Fix-MultiSelect-download
branch
from
88b3bcd
to
24910a2
Compare
JorisBodin
approved these changes
Mar 31, 2022
KevinBoulongne
force-pushed
the
Fix-MultiSelect-download
branch
from
24910a2
to
115ba93
Compare
KevinBoulongne
force-pushed
the
Fix-MultiSelect-download
branch
2 times, most recently
from
4b89814
to
3899b72
Compare
KevinBoulongne
force-pushed
the
Fix-MultiSelect-download
branch
from
3899b72
to
c2a6ccc
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
sirambd
requested changes
Apr 5, 2022
| ) { | ||
| super.onMenuButtonClicked( | ||
| multiSelectBottomSheet = FavoritesMultiSelectActionsBottomSheetDialog(), | ||
| areAllFromTheSameFolder = false, |
There was a problem hiding this comment.
I think it's better to set areAllFromTheSameFolder =false by default.
To avoid dupplications because here I find 7 occurrences.
| emit(ApiRepository.getUUIDArchiveFiles(AccountUtils.currentDriveId, fileIds)) | ||
| } | ||
| private fun download() { | ||
| if (navigationArgs.areAllFromTheSameFolder) downloadArchive() else downloadFiles() |
There was a problem hiding this comment.
The problem here is that if you download only one file, it will always download an archive.
Even if it's still weird this action but it would be nice if it was avoided 😅
sirambd
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Boulongne [email protected]