Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly stops BottomSheet when expanded in PreviewSlider #683

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Mar 22, 2022

Closes #670

@LunarX LunarX added the bug Something isn't working label Mar 22, 2022
@LunarX LunarX added this to the 4.1.2 milestone Mar 22, 2022
@LunarX LunarX requested a review from a team as a code owner March 22, 2022 09:55
@LunarX LunarX self-assigned this Mar 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KevinBoulongne KevinBoulongne changed the title Correctly stops bottom sheet when expended in preview slider Correctly stops BottomSheet when expended in PreviewSlider Mar 22, 2022
@KevinBoulongne KevinBoulongne changed the title Correctly stops BottomSheet when expended in PreviewSlider Correctly stops BottomSheet when expanded in PreviewSlider Mar 22, 2022
@KevinBoulongne KevinBoulongne merged commit 9f635c1 into master Mar 22, 2022
@KevinBoulongne KevinBoulongne deleted the bottomsheet-expand branch March 22, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom sheet expands too far in preview slider
3 participants