Change downloading strategy of RecentChanges Fragment #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianDevel
force-pushed
the
enhanced-recent-changes-downloading
branch
2 times, most recently
from
d48b3dc
to
bb97365
Compare
KevinBoulongne
changed the title
KevinBoulongne
approved these changes
Mar 10, 2022
FabianDevel
force-pushed
the
enhanced-recent-changes-downloading
branch
2 times, most recently
from
ff4c8b7
to
062f17b
Compare
JorisBodin
requested changes
Mar 11, 2022
| files = FileController.getRecentChanges(), | ||
| isComplete = true, | ||
| page = 1, | ||
| } else { |
There was a problem hiding this comment.
No error message in case of ... error?
FabianDevel
force-pushed
the
enhanced-recent-changes-downloading
branch
from
23a209d
to
bb30042
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
JorisBodin
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the downloading strategy of RecentChangesFragment from recursive call to progressive call on scroll
closes #553