Handled Critical code smells on SonarCloud

app/src/androidTest/java/com/infomaniak/drive/ApiRepositoryTest.kt

@@ -311,15 +311,17 @@ class ApiRepositoryTest : KDriveTest() {
 
     @Test
     fun manageCategoryLifecycle() {
-        val categoryId = createCategory(userDrive.driveId, "category tests", "#0000FF").let {
+        var name = "category tests"
+        var color = "#0000FF"
+        val categoryId = createCategory(userDrive.driveId, name, color).let {
             assertApiResponse(it)
-            Assert.assertEquals("Name of the category should be equals to 'category tests'", "category tests", it.data?.name)
-            Assert.assertEquals("Color of the category should be equals to blue", "#0000FF", it.data?.color)
+            Assert.assertEquals("Name of the category should be equals to '$name'", name, it.data?.name)
+            Assert.assertEquals("Color of the category should be equals to blue", color, it.data?.color)
             it.data!!.id
         }
 
         // Create again the same category should fail
-        with(createCategory(userDrive.driveId, "category tests", "#0000FF")) {
+        with(createCategory(userDrive.driveId, name, color)) {
             Assert.assertFalse(isSuccess())
             Assert.assertEquals(
                 "Error description should be 'category already exist error'",
@@ -328,16 +330,19 @@ class ApiRepositoryTest : KDriveTest() {
             )
         }
 
-        with(editCategory(userDrive.driveId, categoryId, "update cat", "#FF0000")) {
+        name = "update cat"
+        color = "#FF0000"
+        with(editCategory(userDrive.driveId, categoryId, name, color)) {
             assertApiResponse(this)
-            Assert.assertEquals("Name of the category should be equals to 'update cat'", "update cat", data?.name)
-            Assert.assertEquals("Color of the category should be equals to red", "#FF0000", data?.color)
+            Assert.assertEquals("Name of the category should be equals to '$name'", name, data?.name)
+            Assert.assertEquals("Color of the category should be equals to red", color, data?.color)
         }
 
         assertApiResponse(deleteCategory(userDrive.driveId, categoryId))
         Assert.assertNull(
             "The category shouldn't be found anymore",
-            getCategory(userDrive.driveId).data?.find { cat -> cat.id == categoryId })
+            getCategory(userDrive.driveId).data?.find { cat -> cat.id == categoryId },
+        )
     }
 
     @Test

app/src/main/java/com/infomaniak/drive/utils/AccountUtils.kt

@@ -53,6 +53,8 @@ import java.util.concurrent.TimeUnit
 
 object AccountUtils : CredentialManager {
 
+    private const val DISABLE_AUTO_SYNC = "AccountUtils: disableAutoSync"
+
     private lateinit var userDatabase: UserDatabase
     var reloadApp: (() -> Unit)? = null
 
@@ -122,7 +124,7 @@ object AccountUtils : CredentialManager {
                             val appSyncSettings = UploadFile.getAppSyncSettings()
                             for (driveRemoved in driveRemovedList) {
                                 if (appSyncSettings?.userId == user.id && appSyncSettings.driveId == driveRemoved.id) {
-                                    Sentry.captureMessage("AccountUtils: disableAutoSync")
+                                    Sentry.captureMessage(DISABLE_AUTO_SYNC)
                                     context.disableAutoSync()
                                 }
                                 if (currentDriveId == driveRemoved.id) {
@@ -177,7 +179,7 @@ object AccountUtils : CredentialManager {
         FileController.deleteUserDriveFiles(userRemoved.id)
 
         if (UploadFile.getAppSyncSettings()?.userId == userRemoved.id) {
-            Sentry.captureMessage("AccountUtils: disableAutoSync")
+            Sentry.captureMessage(DISABLE_AUTO_SYNC)
             context.disableAutoSync()
         }
 
@@ -273,7 +275,7 @@ object AccountUtils : CredentialManager {
             UiSettings(context).removeUiSettings()
 
             if (isEnableAppSync()) {
-                Sentry.captureMessage("AccountUtils: disableAutoSync")
+                Sentry.captureMessage(DISABLE_AUTO_SYNC)
                 context.disableAutoSync()
             }