Android unit test #425
Merged
Android unit test #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
FabianDevel
commented
Jan 6, 2022
•
FabianDevel
commented
- Fixing old tests in FileControllerTests
- add tests for api calls (In progress)
FabianDevel
force-pushed
the
android-unit-test
branch
from
5368b52
to
200a85e
Compare
app/src/main/java/com/infomaniak/drive/data/cache/FileController.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/drive/data/api/ApiRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/drive/data/api/ApiRepository.kt
Outdated
Show resolved
Hide resolved
JorisBodin
reviewed
Jan 14, 2022
Comment on lines
475
to
471
| Assert.assertEquals("file id should be the same", it.data?.id, file.id) | ||
| Assert.assertEquals("file name should be updated to 'Trash test'", newName, it.data?.name) |
There was a problem hiding this comment.
If data is null, the test will not be run, so don't do this
app/src/androidTest/java/com/infomaniak/drive/ApiRepositoryTest.kt
Outdated
Show resolved
Hide resolved
add a first test for getFileById() method
test not important for now
add first parts of api tests
Found a bug on private dropbox deletion
Add a todo for api-v2
To test trashLifecycle, replace the drive id in env file with the empty drive To test dropboxLifeCycle, use the infomaniak dev test drive
FabianDevel
force-pushed
the
android-unit-test
branch
from
e33fd9e
to
f8faf20
Compare
replace .also
JorisBodin
approved these changes
Jan 24, 2022
sirambd
approved these changes
Jan 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.