Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more sentry log in uploadWorker and remove useless logs #395

Merged
merged 3 commits into from
Dec 13, 2021

Conversation

sirambd
Copy link
Member

@sirambd sirambd commented Dec 3, 2021

Fix: #392

java.lang.IllegalStateException: Cannot call this method while RecyclerView is computing a layout or scrolling androidx.recyclerview.widget.RecyclerView{85e3163 VFED..... ......ID 0,0-1080,1887 #7f0a022e app:id/fileRecyclerView}, adapter:com.infomaniak.drive.ui.fileList.FileAdapter@6d8695f, layout:androidx.recyclerview.widget.LinearLayoutManager@8b9ffac, context:com.infomaniak.drive.ui.MainActivity@e4d292c
    at androidx.recyclerview.widget.RecyclerView.assertNotInLayoutOrScroll(RecyclerView.java:3185)
    at androidx.recyclerview.widget.RecyclerView$RecyclerViewDataObserver.onItemRangeRemoved(RecyclerView.java:5728)
    at androidx.recyclerview.widget.RecyclerView$AdapterDataObservable.notifyItemRangeRemoved(RecyclerView.java:12694)
    at androidx.recyclerview.widget.RecyclerView$Adapter.notifyItemRemoved(RecyclerView.java:7738)
    at com.infomaniak.drive.ui.fileList.FileAdapter.hideLoading(FileAdapter.kt:150)
    at com.infomaniak.drive.ui.fileList.FileAdapter.setFiles(FileAdapter.kt:106)
    at com.infomaniak.drive.ui.fileList.UploadInProgressFragment$closeItemClicked$1.invokeSuspend(UploadInProgressFragment.kt:198)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
    at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)

Signed-off-by: Abdourahamane BOINAIDI [email protected]

@sirambd sirambd added documentation Improvements or additions to documentation help wanted Extra attention is needed question Further information is requested labels Dec 3, 2021
@sirambd sirambd requested a review from a team December 3, 2021 15:55
@sirambd sirambd self-assigned this Dec 3, 2021
@sirambd sirambd linked an issue Dec 9, 2021 that may be closed by this pull request
@JorisBodin JorisBodin added this to the 4.1.0 milestone Dec 13, 2021
@JorisBodin JorisBodin merged commit 764b04b into master Dec 13, 2021
@JorisBodin JorisBodin deleted the upload-sentry-log branch December 13, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry - Fix Invalid item position from fileAdapter
3 participants