Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle preview file protected #1049

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Handle preview file protected #1049

merged 3 commits into from
Oct 18, 2023

Conversation

sirambd
Copy link
Member

@sirambd sirambd commented Oct 13, 2023

Depends on #1048

@sirambd sirambd added the feature A new functionality is added to the product label Oct 13, 2023
@sirambd sirambd self-assigned this Oct 13, 2023
@sirambd sirambd requested a review from a team as a code owner October 13, 2023 08:36
@sirambd sirambd changed the base branch from master to global-refactor October 13, 2023 08:36
@sirambd sirambd force-pushed the handle-preview-file-protected branch from 860f3e3 to 41bd845 Compare October 18, 2023 13:43
Base automatically changed from global-refactor to master October 18, 2023 13:48
KevinBoulongne
KevinBoulongne requested changes Oct 18, 2023
View reviewed changes
app/src/main/res/values-fr/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JorisBodin JorisBodin merged commit aab586e into master Oct 18, 2023
2 of 3 checks passed
@JorisBodin JorisBodin deleted the handle-preview-file-protected branch October 18, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorisBodin JorisBodin JorisBodin approved these changes

@KevinBoulongne KevinBoulongne Awaiting requested review from KevinBoulongne

Assignees

@sirambd sirambd

Labels
feature A new functionality is added to the product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirambd @KevinBoulongne @JorisBodin