Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pt.properties #28

Closed
wants to merge 1 commit into from
Closed

Conversation

leof36
Copy link
Contributor

@leof36 leof36 commented Apr 12, 2013

Add vietnamese language - vi

@Infocatcher
Copy link
Owner

Thanks!
But I have some comments.

  1. Not translated: privateTabTip=(private tab)
    This is label in tab tooltip:

Label in tab tooltip

2) I think, you should also translate accesskeys: I see only something like "Thẻ Mới" (label="Thẻ Mới", accesskey="T") in Firefox localization. See https://developer.mozilla.org/en-US/docs/XUL/Tutorial/Accesskey_display_rules#Basic_accesskey_display_rules

@leof36
Copy link
Contributor Author

leof36 commented Apr 12, 2013

Thanks for pointing out my omissions. I will fix it in patch.

@Infocatcher
Copy link
Owner

I will fix it in patch.

Thanks, merged.

And now this issue can be closed, since corrected #32 was closed. :)

@leof36 leof36 deleted the patch-2 branch April 13, 2013 15:20
@Infocatcher
Copy link
Owner

I added new localizable strings and extension now can be localized using babelzilla:
http://www.babelzilla.org/forum/index.php?showtopic=7393

@Infocatcher
Copy link
Owner

I added new localizable strings, see #101 (comment) (also updated on babelzilla).
And now you can subscribe to above issue to receive notifications about future changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants